Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request.endpoint always None in SessionInterface.open_session #3776

Closed
zeha opened this issue Oct 3, 2020 · 2 comments · Fixed by #3794
Closed

request.endpoint always None in SessionInterface.open_session #3776

zeha opened this issue Oct 3, 2020 · 2 comments · Fixed by #3794
Labels
bug
Milestone
2.0.0

Comments

@zeha
Copy link

zeha commented Oct 3, 2020 •
edited

Expected Behavior

Session Interface should have access to request.endpoint from open_session. In Versions before 1.1.0, this worked fine.

Actual Behavior

Our SessionInterface subclass looks at request.endpoint to determine if it should open a new session - opening a new is only appropriate on some endpoints. Now this is always None, so it cannot make this distinction anymore.

I believe #3104 (issue #3088) broke this.

Environment

  • Python version: 3.8.5
  • Flask version: 1.1.2
  • Werkzeug version: 0.16.1
mbpreble pushed a commit to mbpreble/flask that referenced this issue Oct 17, 2020
Ensure session_interface.open_session is called after URL matching (p…
22d491d 
…allets#3776)
@mbpreble mbpreble mentioned this issue Oct 17, 2020
Merged
@mbpreble
Copy link

Added a PR here which is simple enough - URL matching was happening immediately after session creation, now it happens immediately after.

davidism pushed a commit to mbpreble/flask that referenced this issue Feb 2, 2021
@davidism
Ensure session_interface.open_session is called after URL matching (p…
0162148 
…allets#3776)
@davidism davidism added this to the 2.0.0 milestone Feb 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2021
@davidism
Copy link
Member

Planning to roll this back, see #4053

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Ensure session_interface.open_session is called after URL matching mbpreble/flask
4 participants
@zeha @davidism @mbpreble @teymour-aldridge