Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom jinja environments #1422

Merged
merged 1 commit into from Jun 6, 2015

Conversation

@ThiefMaster
Copy link
Member

commented Apr 6, 2015

This is useful e.g. when using the new Jinja Environment
attributes added in pallets/jinja#404

Allow custom jinja environments
This is useful e.g. when using the new Jinja Environment
attributes added in pallets/jinja#404
@@ -157,6 +157,11 @@ class Flask(_PackageBoundObject):
#: :class:`~flask.Response` for more information.
response_class = Response

#: The class that is used for the Jinja environment.
#:
#: .. versionadded:: 0.11

This comment has been minimized.

Copy link
@ThiefMaster

ThiefMaster Apr 6, 2015

Author Member

Not sure if this should be 0.11 or 1.0 - currently both versions are used, with 1.0 being more common but the current package version in flask/__init__.py being 0.11

This comment has been minimized.

Copy link
@untitaker

untitaker Apr 6, 2015

Member

I always assumed it is 1.0 but I'm not sure whether we should release an intermediate version.

This comment has been minimized.

Copy link
@ThiefMaster

ThiefMaster Apr 11, 2015

Author Member

Hm I guess for now the different versions don't really matter as long as it's cleaned up before whatever the next release's version number will be ;)

@ThiefMaster ThiefMaster force-pushed the ThiefMaster:override-jinja-env branch from 7d5bde9 to 08ac3aa Apr 6, 2015

@untitaker untitaker merged commit 08ac3aa into pallets:master Jun 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@untitaker

This comment has been minimized.

Copy link
Member

commented Jun 6, 2015

Thanks @ThiefMaster!

untitaker added a commit that referenced this pull request Jun 6, 2015

@ThiefMaster ThiefMaster deleted the ThiefMaster:override-jinja-env branch Jun 6, 2015

@davidism davidism removed the needs review label Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.