New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix some typos in config.rst #2918

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@garenchan
Contributor

garenchan commented Sep 21, 2018

Fix some typos in config.rst

@garenchan garenchan closed this Sep 21, 2018

@garenchan garenchan reopened this Sep 21, 2018

@@ -53,7 +53,7 @@ In order to set the environment and debug mode reliably, Flask uses
environment variables.
The environment is used to indicate to Flask, extensions, and other
programs, like Sentry, what context Flask is running in. It is
programs, like Sentry, what context they are running in. It is

This comment has been minimized.

@davidism

davidism Sep 21, 2018

Member

This is correct as-is. The paragraph is talking specifically about Flask's environment (app.env, FLASK_ENV).

@@ -222,7 +222,7 @@ The following configuration values are used internally by Flask:
If ``session.permanent`` is true, the cookie's expiration will be set this
number of seconds in the future. Can either be a
:class:`datetime.timedelta` or an ``int``.
:class:`datetime.timedelta` or a ``float``.

This comment has been minimized.

@davidism

davidism Sep 21, 2018

Member

I'd rather these stay as int, accepting a float is only a side effect of how timedelta parses the value, and it's not really useful here.

@davidism

This comment has been minimized.

Member

davidism commented Sep 21, 2018

Please make docs changes against 1.0-maintenance (unless they have to do with new features). Otherwise the changes will only appear in the dev version of the docs.

@garenchan garenchan changed the base branch from master to 1.0-maintenance Sep 21, 2018

@garenchan garenchan changed the base branch from 1.0-maintenance to master Sep 21, 2018

@garenchan

This comment has been minimized.

Contributor

garenchan commented Sep 21, 2018

@davidism, do you mean that document related PR should be based on the 1.0-maintenance branch?

@davidism

This comment has been minimized.

Member

davidism commented Sep 21, 2018

Yes

@garenchan garenchan closed this Sep 21, 2018

@garenchan garenchan reopened this Sep 21, 2018

@garenchan

This comment has been minimized.

Contributor

garenchan commented Sep 21, 2018

There are some docs changes in the dev version that are also useful for 1.0-maintenance. If these commits aren't merged into 1.0-maintenance, the next change will be cumbersome.

@davidism

This comment has been minimized.

Member

davidism commented Sep 21, 2018

I know, I'm working on cherry picking them.

@garenchan

This comment has been minimized.

Contributor

garenchan commented Sep 21, 2018

Thank you for your hard work!

@garenchan garenchan changed the title from Docs: fix some errors in config.rst to Docs: fix some typos in config.rst Sep 23, 2018

@davidism davidism added docs and removed docs labels Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment