New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2937: Ensure the consistency in load_dotenv's return type #2939

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@sharmaadarsh563

sharmaadarsh563 commented Oct 11, 2018

In the flask.cli module, the load_dotenv function is not consistent in its return type. It should either return True or False depending on whether it has loaded the file or not, respectively.

Issue: #2937

Commit checklist:

  • add tests that fail without the patch

  • ensure all tests pass with pytest

  • add documentation to the relevant docstrings or pages

  • add versionadded or versionchanged directives to relevant docstrings

  • add a changelog entry if this patch changes code

@sharmaadarsh563 sharmaadarsh563 changed the title from Fix #2937: Ensure the consitency in return type in load_dotenv to Fix #2937: Ensure the consistency in load_dotenv's return type Oct 11, 2018

@greyli greyli added the cli label Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment