Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2943: Allow bytesio partial content #2957

Merged
merged 2 commits into from Jan 7, 2019

Conversation

@IgnasiBosch
Copy link
Contributor

commented Oct 20, 2018

In helpers.py when file is a BytesIO, fsize was not setted. It should be setted.

Issue: #2943

  • add tests that fail without the patch
  • ensure all tests pass with pytest
  • add documentation to the relevant docstrings or pages
  • add versionadded or versionchanged directives to relevant docstrings
  • add a changelog entry if this patch changes code

IgnasiBosch and others added some commits Oct 18, 2018

@davidism davidism force-pushed the IgnasiBosch:2943-bytesio-partial-content branch from ab530ea to 366f3f4 Jan 7, 2019

@davidism davidism added this to the 1.1 milestone Jan 7, 2019

@davidism davidism merged commit 4f32c6d into pallets:master Jan 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.