Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing url map class #3069

Merged

Conversation

@shidenggui
Copy link
Contributor

commented Jan 8, 2019

For speeding up url route matching, I defined a custom rule class and a custom url map class. But Flask currently only allows modifying url rule class, it should support modify url map class too.

    #: The rule object to use for URL rules created.  This is used by
    #: :meth:`add_url_rule`.  Defaults to :class:`werkzeug.routing.Rule`.
    #:
    #: .. versionadded:: 0.7
    url_rule_class = Rule
@ThiefMaster

This comment has been minimized.

Copy link
Member

commented Jan 8, 2019

FYI, your commit isn't properly linked to your GitHub account (different email).

@miguelgrinberg miguelgrinberg added question and removed question labels Jan 13, 2019

@davidism davidism added this to the 1.1.0 milestone May 19, 2019

@davidism davidism force-pushed the shidenggui:feature_allow_customizing_url_map branch from 1dbbc1a to 2a2a11b May 19, 2019

@davidism davidism merged commit 05102f6 into pallets:master May 19, 2019

12 checks passed

Flask Build #20190519.11 succeeded
Details
Flask (Flask DocsHtml) Flask DocsHtml succeeded
Details
Flask (Flask Pypy3Linux) Flask Pypy3Linux succeeded
Details
Flask (Flask Python27Linux) Flask Python27Linux succeeded
Details
Flask (Flask Python27Windows) Flask Python27Windows succeeded
Details
Flask (Flask Python35Linux) Flask Python35Linux succeeded
Details
Flask (Flask Python36Linux) Flask Python36Linux succeeded
Details
Flask (Flask Python37Linux) Flask Python37Linux succeeded
Details
Flask (Flask Python37Mac) Flask Python37Mac succeeded
Details
Flask (Flask Python37Windows) Flask Python37Windows succeeded
Details
Flask (Flask VersionRange) Flask VersionRange succeeded
Details
Flask (FlaskOnNightly) FlaskOnNightly succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.