Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dotenv warning to stderr #3285

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@ThiefMaster
Copy link
Member

commented Jul 3, 2019

It was printed to stdout, which broke custom flask subcommands whose output was consumed by scripts (which might expect json or something else that's not just text).

@ThiefMaster ThiefMaster requested a review from davidism Jul 3, 2019

@ThiefMaster ThiefMaster force-pushed the ThiefMaster:dotenv-msg-stderr branch from 389e378 to 975f979 Jul 3, 2019

@davidism

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

This doesn't match the rest of the flask run output, which prints to stdout. Is that going to be an issue?

@ThiefMaster

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

I thought about this too, but flask run is not something that will evr produce output which is useful when processed programmatically, while flask <something> may very much output something that's consumed by another program.

@davidism davidism modified the milestones: 1.1.0, 1.0.4 Jul 3, 2019

@davidism davidism added the cli label Jul 3, 2019

@davidism davidism merged commit c074759 into pallets:1.0.x Jul 3, 2019

12 checks passed

Tests Build #20190703.2 succeeded
Details
Tests (Flask DocsHtml) Flask DocsHtml succeeded
Details
Tests (Flask Pypy3Linux) Flask Pypy3Linux succeeded
Details
Tests (Flask Python27Linux) Flask Python27Linux succeeded
Details
Tests (Flask Python27Windows) Flask Python27Windows succeeded
Details
Tests (Flask Python35Linux) Flask Python35Linux succeeded
Details
Tests (Flask Python36Linux) Flask Python36Linux succeeded
Details
Tests (Flask Python37Linux) Flask Python37Linux succeeded
Details
Tests (Flask Python37Mac) Flask Python37Mac succeeded
Details
Tests (Flask Python37Windows) Flask Python37Windows succeeded
Details
Tests (Flask VersionRange) Flask VersionRange succeeded
Details
Tests (FlaskOnNightly) FlaskOnNightly succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.