Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dotenv warning to stderr #3285

Merged
merged 1 commit into from Jul 3, 2019
Merged

Conversation

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Jul 3, 2019

It was printed to stdout, which broke custom flask subcommands whose output was consumed by scripts (which might expect json or something else that's not just text).

@ThiefMaster ThiefMaster requested a review from davidism Jul 3, 2019
@ThiefMaster ThiefMaster force-pushed the dotenv-msg-stderr branch from 389e378 to 975f979 Jul 3, 2019
@davidism
Copy link
Member

@davidism davidism commented Jul 3, 2019

This doesn't match the rest of the flask run output, which prints to stdout. Is that going to be an issue?

@ThiefMaster
Copy link
Member Author

@ThiefMaster ThiefMaster commented Jul 3, 2019

I thought about this too, but flask run is not something that will evr produce output which is useful when processed programmatically, while flask <something> may very much output something that's consumed by another program.

@davidism davidism added this to the 1.1.0 milestone Jul 3, 2019
@davidism davidism removed this from the 1.1.0 milestone Jul 3, 2019
@davidism davidism added this to the 1.0.4 milestone Jul 3, 2019
@davidism davidism added the cli label Jul 3, 2019
@davidism davidism merged commit c074759 into pallets:1.0.x Jul 3, 2019
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants