Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark --cert option on run as is_eager #4544

Merged
merged 1 commit into from Apr 24, 2022

Conversation

bebleo
Copy link
Contributor

@bebleo bebleo commented Apr 18, 2022

Added is_eager=True to the --cert option on the CLI flask run command so that it is evaluated before --key. This allows the two options to be specified in either order.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 2.1.2 milestone Apr 24, 2022
@davidism davidism force-pushed the mark_run_cert_option_eager branch from 699af7b to 5050a18 Compare Apr 24, 2022
@davidism davidism merged commit 2ec1193 into pallets:2.1.x Apr 24, 2022
13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants