Add ability to configure app with a JSON file #827

Merged
merged 1 commit into from Feb 12, 2014

Conversation

4 participants
@mattupstate
Contributor

mattupstate commented Aug 7, 2013

Thought this would be useful for some people.

My use case stems from the fact that its not trivial to generate a Python file with a deployment tool like Chef. But it is trivial to render a JSON file.

@ericmanlol

This comment has been minimized.

Show comment Hide comment
@ericmanlol

ericmanlol Aug 14, 2013

very interesting matt!

very interesting matt!

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Aug 16, 2013

Nice idea!
Why don't you add error handling for not valid JSON? And what about loading from a string?

ghost commented Aug 16, 2013

Nice idea!
Why don't you add error handling for not valid JSON? And what about loading from a string?

@untitaker

This comment has been minimized.

Show comment Hide comment
@untitaker

untitaker Aug 16, 2013

Member

IMO the default exception messages are good enough, even for IOError.

Member

untitaker commented Aug 16, 2013

IMO the default exception messages are good enough, even for IOError.

@untitaker

This comment has been minimized.

Show comment Hide comment
@untitaker

untitaker Aug 16, 2013

Member

But it looks cool to me, +1.

Member

untitaker commented Aug 16, 2013

But it looks cool to me, +1.

@mattupstate

This comment has been minimized.

Show comment Hide comment
@mattupstate

mattupstate Aug 19, 2013

Contributor

@Gioi I thought mimicking the same behavior as from_pyfile would be appropriate

Contributor

mattupstate commented Aug 19, 2013

@Gioi I thought mimicking the same behavior as from_pyfile would be appropriate

@DasIch DasIch merged commit b290bf4 into pallets:master Feb 12, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment