Allow developer to override X-Sendfile header when USE_X_SENDFILE is in use #951

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@bbenne10

This allows the developer to set which header to send to the webserver. The default is X-Sendfile.

@ThiefMaster
Member

Doesn't lighttpd understand x-sendfile, too?! Because if it does there's not much value in this. The only other webserver that does things differently is nginx - but nginx uses a different thing altogether (URL instead of filesystem path) so just renaming the header won't help.

@bbenne10

Only in 1.5 does Lighttpd understand X-Sendfile. The last stable version is 1.4. (Admittedly, 1.5 has been in RC status since at least 2007...)

I understand that this is limited in its usefulness, but it doesn't add much to the code (2 lines overall without docs) and it does increase somewhat the flexibility of the system itself.

@mitsuhiko
Member

This is better fixed with a WSGI middleware. That's what they are for :)

@mitsuhiko mitsuhiko closed this Feb 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment