Add self.options so options can be retrived from within the blueprint #970

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

With this method I can pass options to the blueprint when registering.
They are then available in the blueprint.

Owner

ThiefMaster commented Feb 5, 2014

Please follow PEP8. I'm also pretty sure that you are not supposed to put your name in a comment like you did (for bigger contributions you'd most likely want to add yourself to AUTHORS but that'd be somewhat strange for a one-line contribution).

Your code should look e.g. like this:

        # Allows to pass options to a blueprint and retrieve them within the blueprint
        self.options_blueprints = options

(I did not look at what value it actually provides. In any case, I don't like the name options_blueprints)

@ThiefMaster My first pull request ever. Thanks for the comment. What should I do next ?

Owner

untitaker commented Feb 6, 2014

Do git commit --amend to make the changes and then git push -f.

Owner

mitsuhiko commented Feb 9, 2014

Not a fan of this because it probably indicates that something messy would be done with this information. Blueprints that want to operate on this information should be subclassed and intercept what they need.

mitsuhiko closed this Feb 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment