Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in date_signed parameter when raising BadTimeSignature vs SignatureExpired #124

Closed
wgwz opened this issue Jan 5, 2019 · 0 comments · Fixed by #154
Closed

Inconsistency in date_signed parameter when raising BadTimeSignature vs SignatureExpired #124

wgwz opened this issue Jan 5, 2019 · 0 comments · Fixed by #154
Milestone
2.0.0

Comments

@wgwz
Copy link

wgwz commented Jan 5, 2019 •
edited

  1. https://github.com/pallets/itsdangerous/blob/master/src/itsdangerous/timed.py#L78-L80
  2. https://github.com/pallets/itsdangerous/blob/master/src/itsdangerous/timed.py#L91-L95

One passes an int while the other converts to datetime even though it's the same parameter. This will add some custom logic for those downstream. Is there any way that we can can pick one for consistency?
@davidism davidism added this to the 2.0.0 milestone Apr 17, 2020
@davidism davidism mentioned this issue Apr 17, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

date_signed is datetime not int pallets/itsdangerous
2 participants
@davidism @wgwz