Skip to content

Deprecate JWS #129

Closed
Closed

Description

@davidism

I'm not very familiar with the standard, so it's hard to maintain. People keep mistaking JWS for JWT and then think we're not implementing things correctly. JWS seems to behave somewhat orthogonally to itsdangerous. There are libraries with dedicated JW* implementations, such as pyjwt or authlib or python-jose. It should still be possible to create a signer subclass that uses these libraries.

Activity

  1. davidism commented on Apr 2, 2019

    @davidism
    MemberAuthor

    #54 has some previous discussion.

  2. lepture commented on Apr 6, 2019

    @lepture
    Contributor

    It is caused by the names used in itsdangerous. If we put names like exp into payload, it is a valid JWT then.

  3. lepture commented on Sep 15, 2019

    @lepture
    Contributor

    JWS is not used in Flask. I think we can remove it from itsdangerous.

  4. aviau commented on Oct 8, 2019

    @aviau

    Ah. That's unfortunate. Given the popularity of itsdangerous I would expect that the JWS implementation has a large number of users.

  5. added this to the 2.0.0 milestone on Apr 14, 2020
  6. locked as resolved and limited conversation to collaborators on Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions