Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fallback signer #155

Closed
davidism opened this issue May 9, 2020 · 0 comments · Fixed by #157
Closed

Remove the fallback signer #155

davidism opened this issue May 9, 2020 · 0 comments · Fixed by #157
Milestone

Comments

@davidism
Copy link
Member

davidism commented May 9, 2020

In order to mitigate a change/revert to the default digest method from/back to sha1, fallback signers were implemented and sha512 was left as a default fallback signer. This default fallback was always intended as temporary. Remove it and make the default fallback signers empty.

Note that the security of the hash alone doesn't apply when used intermediately in HMAC. SHA-1, and even MD5, is still secure when used in HMAC. The change to SHA-512 was done for optics at the time, but caused backwards compatibility issues and greatly increased the size of the signed values. If a project is concerned beyond this, it is possible to configure the digest method however they want, as well as include fallback signers to upgrade old tokens.

@davidism davidism added this to the 2.0.0 milestone May 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant