Skip to content

Handle OverflowError on parsing timestamps as BadTimeSignature#299

Merged
davidism merged 1 commit intopallets:2.1.xfrom
dirkmueller:main
Mar 24, 2022
Merged

Handle OverflowError on parsing timestamps as BadTimeSignature#299
davidism merged 1 commit intopallets:2.1.xfrom
dirkmueller:main

Conversation

@dirkmueller
Copy link
Copy Markdown
Contributor

@dirkmueller dirkmueller commented Mar 24, 2022

on 32bit platforms the test TestTimestampSigner::test_malformed_future_timestamp
causes an OverflowError. Catch this and raise it as BadTimeSignature

Signed-off-by: Dirk Müller dirk@dmllr.de

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 2.1.2 milestone Mar 24, 2022
@davidism davidism changed the base branch from main to 2.1.x March 24, 2022 14:58
@davidism davidism merged commit 64cd581 into pallets:2.1.x Mar 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

catch overflow error on 32bit platforms

2 participants