Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle OverflowError on parsing timestamps as BadTimeSignature #299

merged 1 commit into from
Mar 24, 2022


Copy link

@dirkmueller dirkmueller commented Mar 24, 2022

on 32bit platforms the test TestTimestampSigner::test_malformed_future_timestamp
causes an OverflowError. Catch this and raise it as BadTimeSignature

Signed-off-by: Dirk Müller


  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 2.1.2 milestone Mar 24, 2022
@davidism davidism changed the base branch from main to 2.1.x March 24, 2022 14:58
@davidism davidism merged commit 64cd581 into pallets:2.1.x Mar 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

catch overflow error on 32bit platforms
2 participants