Async is slow due to isawaitable use #1514

Activity

1. davidism commented on Oct 16, 2021

   

   davidism

   on Oct 16, 2021

   Member

   More actions

   Sounds like something that should be reported to CPython so they can improve its performance. I don't see what Jinja could do about this.
2. mohd-akram commented on Oct 16, 2021

   

   mohd-akram

   on Oct 16, 2021

   ContributorAuthor

   More actions

   I'm getting anywhere between 15% to 2x improvement with this change:

   primitives = {int, float, bool, str, list, dict, tuple}
   
   async def auto_await(value: t.Union[t.Awaitable["V"], "V"]) -> "V":
       if type(value) in primitives:
           return t.cast("V", value)
   
       if inspect.isawaitable(value):
           return await t.cast("t.Awaitable[V]", value)
   
       return t.cast("V", value)

   Since most objects are primitives, we can avoid a costly check.
3. davidism commented on Oct 16, 2021

   

   davidism

   on Oct 16, 2021

   Member

   More actions

   Happy to review a PR.
4. davidism

   added this to the 3.0.3 milestone on Nov 9, 2021
5. davidism

   closed this as completedon Nov 9, 2021
6. github-actions

   locked as resolved and limited conversation to collaborators on Nov 24, 2021