Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrefixLoader does not pass globals to load (with fix) #225

Closed
duxiaoyao opened this issue May 22, 2013 · 4 comments
Closed

PrefixLoader does not pass globals to load (with fix) #225

duxiaoyao opened this issue May 22, 2013 · 4 comments

Comments

@duxiaoyao
Copy link

@duxiaoyao duxiaoyao commented May 22, 2013

After upgraded to 2.7, my app got an error:
UndefinedError: 'static_url' is undefined
where 'static_url' is a global function. And this worked before the upgrade.

It works after changing line 352 in loaders.py as below:
return loader.load(environment, local_name)
=>
return loader.load(environment, local_name, globals)

@mw44118
Copy link

@mw44118 mw44118 commented Jul 24, 2013

This is preventing us from using jinja 2.7

@MorrisJobke
Copy link

@MorrisJobke MorrisJobke commented Jul 24, 2013

@mw44118 Have you tested my open pull request?

@mw44118
Copy link

@mw44118 mw44118 commented Jul 24, 2013

No, I didn't apply it, but I did the exact same thing to fix the bug
locally, so I'm confident your patch is legit :)

On Wed, Jul 24, 2013 at 10:54 AM, Morris Jobke notifications@github.comwrote:

@mw44118 https://github.com/mw44118 Have you tested my open pull
request?


Reply to this email directly or view it on GitHubhttps://github.com//issues/225#issuecomment-21490460
.

W. Matthew Wilson
matt@tplus1.com
http://tplus1.com

@davidism
Copy link
Member

@davidism davidism commented Oct 25, 2019

Fixed in 2.7.2, 701e9ad

@davidism davidism closed this Oct 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants