Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`{{ 'foo' if false }}` shortcut not usable with StrictUndefined #710

Closed
ThiefMaster opened this issue May 7, 2017 · 0 comments · Fixed by #1079
Closed

`{{ 'foo' if false }}` shortcut not usable with StrictUndefined #710

ThiefMaster opened this issue May 7, 2017 · 0 comments · Fixed by #1079
Milestone

Comments

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented May 7, 2017

Using the shortcut version of the ternary operator with no else implies else <undefined>. This is fine when using the normal Undefined but makes this shortcut basically useless with StrictUndefined (and to some extent LoggingUndefined).

>>> from jinja2 import StrictUndefined, Environment
>>> env = Environment(undefined=StrictUndefined)
>>> env.from_string('{{ "foo" if false }}').render()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/adrian/.python-env/lib/python2.7/site-packages/jinja2/environment.py", line 989, in render
    return self.environment.handle_exception(exc_info, True)
  File "/home/adrian/.python-env/lib/python2.7/site-packages/jinja2/environment.py", line 754, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "<template>", line 1, in top-level template code
jinja2.exceptions.UndefinedError: the inline if-expression on line 1 evaluated to false and no else section was defined.

I'd change the default from <undefined> to '' - like this the behavior of existing templates will not change (empty output) but it would work fine with the stricter Undefined variants.

The only breakage I could imagine is someone using it in a function/macro call with an explicit is defined check later on. But I think that's rather unlikely and if necessary a new policy option could be added to make it default to <undefined> again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.