Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'callable' instead of typechecking for runtime calls ctx/env injection #1108

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@captainmalloc
Copy link
Contributor

captainmalloc commented Nov 19, 2019

When jinja2 is used from Cython-compiled code, Functions and Methods are not types.FunctionType or types.MethodType anymore. Instead they are cython_function_or_method. The framework does not recognize decorated functions/methods and doesn't inject the needed parameters before the call execution.

Using callable is backward compatible with existing implementation and also compatible with Cython-compiled code.

@davidism davidism added this to the 2.11.0 milestone Nov 20, 2019
@davidism davidism force-pushed the captainmalloc:runtime_calls branch from 31ec1bd to 70ea1d3 Nov 20, 2019
@davidism davidism merged commit c206cc9 into pallets:master Nov 20, 2019
10 checks passed
10 checks passed
Tests #20191120.1 succeeded
Details
Tests (Job Docs) Job Docs succeeded
Details
Tests (Job PyPy 3 Linux) Job PyPy 3 Linux succeeded
Details
Tests (Job Python 2.7 Linux) Job Python 2.7 Linux succeeded
Details
Tests (Job Python 2.7 Windows) Job Python 2.7 Windows succeeded
Details
Tests (Job Python 3.5 Linux) Job Python 3.5 Linux succeeded
Details
Tests (Job Python 3.6 Linux) Job Python 3.6 Linux succeeded
Details
Tests (Job Python 3.7 Linux) Job Python 3.7 Linux succeeded
Details
Tests (Job Python 3.7 Mac) Job Python 3.7 Mac succeeded
Details
Tests (Job Python 3.7 Windows) Job Python 3.7 Windows succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.