Revert dropping pkg_resources from PackageLoader for 2.11 #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
revert-package-loader
branch
from
f9bf2ad
to
35a2ba5
Compare
This was referenced Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#1168 reports that
PackageLoaderno longer works when the package is being tested by Pytest. This is because the rewrite to remove pkg_resources depends on Pytest's rewrite hook providing behavior that is only optional according to PEP 451. The fix was to use other APIs provided by PEP 451 #1169, but that turned out to be incompatible with Python 2. Therefore the changes are reverted in 2.11, and instead will only be present in 3.0.