Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dropping pkg_resources from PackageLoader for 2.11 #1182

merged 3 commits into from Mar 30, 2020


Copy link

#1168 reports that PackageLoader no longer works when the package is being tested by Pytest. This is because the rewrite to remove pkg_resources depends on Pytest's rewrite hook providing behavior that is only optional according to PEP 451. The fix was to use other APIs provided by PEP 451 #1169, but that turned out to be incompatible with Python 2. Therefore the changes are reverted in 2.11, and instead will only be present in 3.0.

@davidism davidism added this to the 2.11.2 milestone Mar 30, 2020
@davidism davidism merged commit 07b5c01 into 2.11.x Mar 30, 2020
@davidism davidism deleted the revert-package-loader branch March 30, 2020 17:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant