Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __aiter__ to Undefined #1294

Merged
merged 1 commit into from Apr 5, 2021

Conversation

Jafnee
Copy link

@Jafnee Jafnee commented Sep 23, 2020

Allows iterating over ChainableUndefined when using render_async.

Added __aiter__ method to Undefined which ChainableUndefined inherits from.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@Jafnee Jafnee changed the base branch from master to 2.11.x September 23, 2020 10:46
@Jafnee Jafnee changed the title Chainableundefined aiter bug Add __aiter__ to Undefined Sep 23, 2020
@Jafnee Jafnee marked this pull request as ready for review September 23, 2020 10:52
@davidism davidism added this to the 3.0.0 milestone Mar 27, 2021
@davidism davidism added the async label Mar 27, 2021
@davidism davidism force-pushed the chainableundefined-aiter-bug branch from 9b21e9c to 3242428 Compare April 5, 2021 17:51
@davidism davidism changed the base branch from 2.11.x to master April 5, 2021 17:53
@davidism davidism merged commit 06c7c6f into pallets:master Apr 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: 'async for' requires an object with __aiter__ method, got ChainableUndefined
2 participants