Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport urlize speedup #1343

Merged
merged 1 commit into from Jan 31, 2021
Merged

backport urlize speedup #1343

merged 1 commit into from Jan 31, 2021

Conversation

@davidism
Copy link
Member

@davidism davidism commented Jan 31, 2021

Match leading and trailing punctuation as separate steps. For trailing punctuation, perform a basic check first to reduce backtracking. Update the email regex to reduce backtracking and also be more accurate: the domain part must start with a word character, and the tld only matches word characters.

This is backported from #1195, but only includes the regex speedups, not the other changes.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.
@davidism
Copy link
Member Author

@davidism davidism commented Jan 31, 2021

Confirmed that all 2.11.x supported Pythons pass in Tox locally, since CI isn't configured on this branch anymore.

@davidism davidism merged commit 15ef8f0 into 2.11.x Jan 31, 2021
1 check passed
@davidism davidism deleted the urlize-speedup branch Jan 31, 2021
@davidism davidism added this to the 2.11.3 milestone Jan 31, 2021
earthgecko added a commit to earthgecko/skyline that referenced this issue Feb 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant