Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce async overhead due to auto_await #1516

Merged
merged 1 commit into from Nov 9, 2021
Merged

Conversation

@mohd-akram
Copy link
Contributor

@mohd-akram mohd-akram commented Oct 18, 2021

The types of most rendered values tend to be primitives, so we can avoid a costly call to inspect.isawaitable for them. This improves performance by at least 15% in my tests.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.
@mohd-akram
Copy link
Contributor Author

@mohd-akram mohd-akram commented Nov 4, 2021

@davidism Have you had a chance to look at this?

@davidism
Copy link
Member

@davidism davidism commented Nov 4, 2021

No not yet. When I do, I'll leave a review, comment, or merge and you'll get a notification.

@davidism davidism added this to the 3.0.3 milestone Nov 9, 2021
@davidism davidism changed the base branch from main to 3.0.x Nov 9, 2021
@davidism davidism merged commit c0130ea into pallets:3.0.x Nov 9, 2021
12 checks passed
@mohd-akram mohd-akram deleted the async-perf branch Nov 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants