Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify CodeType rewriting #1536

Merged
merged 1 commit into from Nov 9, 2021
Merged

simplify CodeType rewriting #1536

merged 1 commit into from Nov 9, 2021

Conversation

@davidism
Copy link
Member

@davidism davidism commented Nov 9, 2021

Use CodeType.replace to greatly simplify replacing co_name on Python 3.8+. Only Python 3.7 needs to use all positional arguments. No longer need to replace co_filename, it's already replaced by compile. Remove try/except block to avoid hiding errors with this code in the future; need to test that modern GAE works with this.

fixes #1334

@davidism davidism added this to the 3.0.3 milestone Nov 9, 2021
@davidism
Copy link
Member Author

@davidism davidism commented Nov 9, 2021

From what I can see from https://cloud.google.com/appengine/docs/standard/runtimes and other docs, the modern GAE runtime is unmodified, unlike the legacy Python 2 runtime. Based on that, I'm going to merge this.

@davidism davidism merged commit a4e2532 into 3.0.x Nov 9, 2021
12 checks passed
@davidism davidism deleted the traceback-codetype branch Nov 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant