force a reload of the template if bytecode fails to unmarshall. issue #... #282

Merged
merged 2 commits into from Jun 6, 2014

Conversation

Projects
None yet
3 participants

Fix for issue #281. Please let me know if there's anything else I can do to help or get this merged in.

Owner

untitaker commented Nov 22, 2013

I think you should catch marshalling errors explicitly.

Thanks for getting back to me so fast!

Catching all exceptions that marshal throws explicitly now.

I should note here that the only error I was able to reproduce was the EOFError. I can just catch this exception explicitly and allow the others to bubble up if you would prefer.

My line of thinking for going ahead and capturing all three marshal exceptions was that any type of error loading cached bytecode should result in the same result: Invalidate the cache and reload the template from source.

Thanks again. I appreciate your time.

@mitsuhiko mitsuhiko added a commit that referenced this pull request Jun 6, 2014

@mitsuhiko mitsuhiko Merge pull request #282 from timhanus/master
force a reload of the template if bytecode fails to unmarshall.  issue #...
8a0358e

@mitsuhiko mitsuhiko merged commit 8a0358e into pallets:master Jun 6, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment