Add equalto test as value-level analogue of reference-level sameas test. #283

Merged
merged 2 commits into from Dec 12, 2013

Projects

None yet

3 participants

@thomasvnoort
Contributor

I was missing a test for value-level equality, analogue to the sameas test that compares pointers. For instance, to filter a hash like {{ users|selectattr("email", "equalto", "jinja@pocoo.org") }}.

@berkerpeksag
Contributor

It would be good to add a test to jinja2/testsuite/tests.py.

@thomasvnoort
Contributor

I don't mean to be impatient, but is somebody looking into merging this pull request? To me it seems like a simple yet powerful addition.

@mitsuhiko
Member

That sounds like a good idea for the new filter support.

@mitsuhiko mitsuhiko merged commit 40367c4 into pallets:master Dec 12, 2013

1 check passed

default The Travis CI build passed
Details
@mitsuhiko
Member

Sorry for not handling this for so long. I'm trying to fix this. For the time being, send me an email if you have any more requests that need proper review to jump ahead of the github notification list.

@thomasvnoort
Contributor

Wonderful, thanks for your quick reply!

@thomasvnoort thomasvnoort deleted the silkapp:equalto-test branch Dec 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment