Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CodeGenerator and Context overridable #404

Closed

Conversation

@ThiefMaster
Copy link
Member

ThiefMaster commented Apr 6, 2015

It's probably not needed very often, but subclassing e.g. the Environment to use a custom class for it would be so much cleaner than having to monkey-patch or fork.

ThiefMaster added a commit to ThiefMaster/jinja that referenced this pull request Apr 6, 2015
ThiefMaster added a commit to ThiefMaster/jinja that referenced this pull request Apr 6, 2015
ThiefMaster added a commit to ThiefMaster/jinja that referenced this pull request Apr 6, 2015
ThiefMaster added a commit to ThiefMaster/jinja that referenced this pull request Apr 6, 2015
@ThiefMaster ThiefMaster force-pushed the ThiefMaster:override-codegen-context branch from 95eb002 to f22fdd5 Apr 6, 2015
@untitaker

This comment has been minimized.

Copy link
Member

untitaker commented Apr 6, 2015

I'm really confused by your commit referencing the PR itself but the diff checks out.

@ThiefMaster

This comment has been minimized.

Copy link
Member Author

ThiefMaster commented Apr 6, 2015

Initially I was going to open a separate PR, then I remembered that the hub util can convert an existing issue in a PR. I've updated the commits to remove the unneeded reference.

@ThiefMaster ThiefMaster force-pushed the ThiefMaster:override-codegen-context branch from f22fdd5 to abf025e Apr 6, 2015
@untitaker

This comment has been minimized.

Copy link
Member

untitaker commented Apr 6, 2015

I see, I thought that functionality has been removed from Github.

@ThiefMaster

This comment has been minimized.

Copy link
Member Author

ThiefMaster commented Apr 6, 2015

It's deprecated (not sure why, seems to be useful) according to the output of the command:

Warning: Issue to pull request conversion is deprecated and might not work in the future.

@untitaker untitaker closed this in f22fdd5 Apr 6, 2015
untitaker added a commit that referenced this pull request Apr 6, 2015
@untitaker

This comment has been minimized.

Copy link
Member

untitaker commented Apr 6, 2015

Thanks, merged!

@ThiefMaster ThiefMaster deleted the ThiefMaster:override-codegen-context branch Apr 6, 2015
@untitaker

This comment has been minimized.

Copy link
Member

untitaker commented Apr 6, 2015

Regarding that hub feature: github/hub@4f70dd1

ThiefMaster added a commit to ThiefMaster/flask that referenced this pull request Apr 6, 2015
This is useful e.g. when using the new Jinja Environment
attributes added in pallets/jinja#404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.