Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile `elif` tag to `elif` instead of `else: if` #760

Merged
merged 1 commit into from Aug 22, 2017

Conversation

@ThiefMaster
Copy link
Member

commented Aug 22, 2017

This avoids deep nesting in case of many {% elif .. %} blocks (which would fail during execution) and also deep recursion (which may fail during compilation)

fixes #759

@ThiefMaster ThiefMaster requested a review from mitsuhiko Aug 22, 2017

@ThiefMaster ThiefMaster changed the base branch from master to 2.9-maintenance Aug 22, 2017

@mitsuhiko

This comment has been minimized.

Copy link
Member

commented Aug 22, 2017

Meh. Travis is broken. In case this passes it looks good to me though.

Compile `elif` tag to `elif` instead of `else: if`
This avoids deep nesting in case of many `{% elif .. %}` blocks (which
would fail during execution) and also deep recursion (which may fail
during compilation)

fixes #759

@ThiefMaster ThiefMaster force-pushed the ThiefMaster:flat-elif branch from ece0787 to cde2a54 Aug 22, 2017

@ThiefMaster ThiefMaster merged commit cde2a54 into pallets:2.9-maintenance Aug 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ThiefMaster ThiefMaster deleted the ThiefMaster:flat-elif branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.