Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compiler handling of parens around boolean comparisons. #938

Merged
merged 1 commit into from Oct 7, 2019

Conversation

stevenorum
Copy link
Contributor

@stevenorum stevenorum commented Jan 12, 2019

In response to: [BUG] Unexpected TypeError when using boolean test inside numeric expression

Full details in the latest post in that issue.

Not sure if this is the right place for a unit test, or if this is the right test; I didn't see any compiler-specific tests, and I wasn't able to get them running successfully on my laptop. However, I applied the change directly to the installed version of jinja2 and it fixed the problem, and the code in the unit test in the commit executes as desired when run on its own.

@davidism davidism added this to the 2.11.0 milestone Oct 7, 2019
@davidism davidism merged commit f1d199a into pallets:master Oct 7, 2019
1 check passed
davidism added a commit that referenced this issue Oct 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants