Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Loop properties revindex and revindex0 still wrong in Jinja2 2.10 #794 #993

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Fix for Loop properties revindex and revindex0 still wrong in Jinja2 2.10 #794 #993

merged 1 commit into from
Oct 14, 2019

Conversation

aayushuppal
Copy link
Contributor

@aayushuppal aayushuppal commented May 6, 2019 •
edited by davidism
Loading

  • The approach to set length param is costly and should be avoided. only if someone expects the iterator length should the cost be borne.
  • Added test cases to validate rendering and LoopContext behavior

fixes #459
fixes #751
fixes #794

@davidism davidism closed this May 6, 2019
@davidism davidism reopened this May 6, 2019
@aayushuppal
Copy link
Contributor Author

Issue & Fix summary

  • The LoopContext length property implementation was incorrect & suboptimal which in turn messed up the values of revindex revindex0
  • Fixed LoopContext length property implementation
  • Added testcases

@aayushuppal aayushuppal mentioned this pull request Jun 1, 2019
Closed
This was referenced Jun 11, 2019
Merged
Merged
@davidism davidism added this to the 2.11.0 milestone Sep 26, 2019
@davidism davidism mentioned this pull request Oct 13, 2019
Closed
@davidism davidism changed the base branch from 2.10.x to master October 14, 2019 16:11
@davidism davidism changed the base branch from master to 2.10.x October 14, 2019 16:12
@davidism davidism changed the base branch from 2.10.x to master October 14, 2019 16:12
@davidism davidism merged commit 81b3224 into pallets:master Oct 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevin-brown kevin-brown kevin-brown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
3 participants
@aayushuppal @kevin-brown @davidism