Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markupsafe breaks with latest version of setuptools #116

Closed
SgtCoDFish opened this issue Mar 9, 2020 · 4 comments
Closed

Markupsafe breaks with latest version of setuptools #116

SgtCoDFish opened this issue Mar 9, 2020 · 4 comments

Comments

@SgtCoDFish
Copy link

The latest version of setuptools - https://pypi.org/project/setuptools/46.0.0/ released on 2020-03-08 - removed Feature which apparently was a long-deprecated class. There's an issue raised on the repo for setuptools: pypa/setuptools#2017

The following is the output from trying to install markupsafe with the latest version of setuptools.

Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/.../markupsafe/setup.py", line 6, in <module>
        from setuptools import setup, Extension, Feature
    ImportError: cannot import name 'Feature'

For now, we can work around this by pinning setuptools to the last working version 45.3.0 but I suspect that in the long term markupsafe might need to be updated to remove the use of Feature.

This might be something like #23 coming back.
@davidism
Copy link
Member

davidism commented Mar 9, 2020 •
edited

This had been fixed since 0.19, but for some reason a revert to that fix made it into 1.0 (d2001bb), then was removed again in 1.1.

Unless you really need 1.0 for some reason, I'd advise just upgrading to 1.1.1, there shouldn't be any compatibility issues.

@SgtCoDFish
Copy link
Author

Unless you really need 1.0 for some reason, I'd advise just upgrading to 1.1.1, there shouldn't be any compatibility issues.

After a bit of an adventure, I got everything upgraded and can confirm that 1.1.1 cures the problem. Thanks very much!

@advance512
Copy link

Confirm - this happened to me, changing version installed fixed it.

jkkummerfeld pushed a commit to jkkummerfeld/coref that referenced this issue Mar 23, 2020
Increase version of MarkupSafe
b66ab00 
Version 1.0 of MarkupSafe fails to build with the latest version of setuptools (see pallets/markupsafe#116). Shifting to 1.1.1 doesn't seem to break the code and resolves this build issue.
@jkkummerfeld jkkummerfeld mentioned this issue Mar 23, 2020
Open
chriddyp added a commit to plotly/dash-docs that referenced this issue Mar 26, 2020
@chriddyp
upgrade markupsafe
bb90807 
pallets/markupsafe#116
rstijerina added a commit to DesignSafe-CI/portal that referenced this issue Apr 10, 2020
@rstijerina
update Markupsafe version to fix breaking install
270f433 
pallets/markupsafe#116
le-chat pushed a commit to lesh-dev/core that referenced this issue Apr 12, 2020
Обновил версию MarkupSafe до собирающейся современными setuptools. См. …
1f23dc1 
…pallets/markupsafe#116
@maiamcc maiamcc mentioned this issue Apr 20, 2020
Merged
@hankshz hankshz mentioned this issue Apr 23, 2020
Merged
@r39132 r39132 mentioned this issue May 10, 2020
Open
@mo2menelzeiny mo2menelzeiny mentioned this issue May 13, 2020
Merged
Shique added a commit to Shique/scrapy-cluster that referenced this issue May 18, 2020
@Shique
Fixed an error with MarkupSafe installation
f535d85 
MarkupSafe tries to import setuptools.Feature which results in an error as it's deprecated.
Details:
pallets/markupsafe#116
pypa/setuptools#2017
Shique added a commit to Shique/scrapy-cluster that referenced this issue May 18, 2020
@Shique
Fixed an error with MarkupSafe installation
5e20d4a 
MarkupSafe tries to import setuptools.Feature which results in an error as it's deprecated.
Details:
pallets/markupsafe#116
pypa/setuptools#2017
This was referenced May 18, 2020
Merged
Closed
aaron-ikb added a commit to aaron-ikb/microservices-demo-1 that referenced this issue May 25, 2020
@aaron-ikb
Use Markupsafe that actually installs
8467423 
See pallets/markupsafe#116
tchaikov added a commit to tchaikov/ceph that referenced this issue May 28, 2020
@tchaikov
qa/suites/rgw/tempest: bump tempest version from 17 to 20
38859a6 
to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue May 29, 2020
@tchaikov
qa/suites/rgw/tempest: bump tempest version from 17 to 20
6453447 
also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue May 29, 2020
@tchaikov
qa/suites/rgw/tempest: bump tempest version from 17 to 21
9ed1287 
also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue May 29, 2020
@tchaikov
qa/suites/rgw/tempest: bump tempest version from 17 to 18
0e54443 
also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue May 29, 2020
@tchaikov
qa/suites/rgw/tempest: bump tempest version from 17 to 18
31e95cd 
also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue May 29, 2020
@tchaikov
qa/suites/rgw/tempest: bump tempest version from 17 to 18
153b618 
also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue May 31, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
1bc7ba6 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue Jun 2, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
8cb3f04 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
ideepika pushed a commit to ceph/ceph-ci that referenced this issue Jun 4, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
708883a 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov added a commit to tchaikov/ceph that referenced this issue Jun 12, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
dd00bc7 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8cb3f04)
tchaikov added a commit to tchaikov/ceph that referenced this issue Jun 12, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
b4c3f47 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8cb3f04)
kshtsk pushed a commit to kshtsk/ceph that referenced this issue Jun 12, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
380862a 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8cb3f04)
tchaikov added a commit to tchaikov/ceph that referenced this issue Jun 12, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
404a0cf 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8cb3f04)
tchaikov added a commit to tchaikov/ceph that referenced this issue Jun 14, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
151bfde 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8cb3f04)
@ycombinator ycombinator mentioned this issue Jul 21, 2020
Merged
airshipbot pushed a commit to airshipit/drydock that referenced this issue Jul 24, 2020
@AhmadMahmoudi
Added some validations loggs for site model
5063769 
During drydock node deployments, sometimes MaaS node deployment for
some nodes fails when the node tries to pull the node bootaction
files, using drydock api.
Drydock api call fails with `500 Internal Server Error`, when
drydock tries to create the booaction files for the node. The logs,
however do no provide any additional clues on what caused drydock to
fail. This issue does not happen always, and subsequent site updates
will most of the deploy the failed nodes.

The additional checks and logs are added to help pinpoint the root cause
of the 500 return code, if/when this issue heppens again.

This ps also, uplifted `MarkupSafe` pip library from 1.0 to 1.1.1 to
address the issue with MarkupSafe and latest version of setuptools
described here: pallets/markupsafe#116

Change-Id: I08a088d9690d8d9dd1f771dc5e84d1eb02fbd39f
sabbir-006 pushed a commit to sabbir-006/scrapy-cluster that referenced this issue Jul 26, 2020
@Shique @sabbir-006
Fixed an error with MarkupSafe installation
de0070d 
MarkupSafe tries to import setuptools.Feature which results in an error as it's deprecated.
Details:
pallets/markupsafe#116
pypa/setuptools#2017
This was referenced Jul 28, 2020
Open
Open
pacroy added a commit to pacroy/python-sample-vscode-flask-tutorial that referenced this issue Aug 31, 2020
@pacroy
Bump MarkupSafe to v1.1.1 to address issue w/ setuptools
8fabfed 
Ref.Issue: pallets/markupsafe#116
pacroy added a commit to pacroy/python-docs-hello-world that referenced this issue Aug 31, 2020
@pacroy
Bump MarkupSafe to v1.1.1 to address issue w/ setuptools
840e22c 
Ref.Issue: pallets/markupsafe#116
ideepika pushed a commit to ceph/ceph-ci that referenced this issue Sep 3, 2020
@tchaikov
qa/suites/rgw/tempest: use the latest tempest supporting py3.5
29deb49 
in case we need to use ubuntu xenial for testing, xenial only had python
3.5 packaged. and tempest 23.0 was the last version which supports
python3.5 and python2.7.

also do not replace link in tox.ini, as it is reachable.

to address the issues of

- pallets/markupsafe#116
- pypa/setuptools#2017

MarkupSafe is installed by
https://opendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt

Signed-off-by: Kefu Chai <kchai@redhat.com>
fumi232323 added a commit to beproud/beproudbot that referenced this issue Sep 9, 2020
@fumi232323
refs #56 最新の setuptools だとエラーが出るためバージョンアップ (参考: pallets/markupsafe#116)
4104416
@fumi232323 fumi232323 mentioned this issue Sep 9, 2020
Merged
11 tasks
@jesusroncal94 jesusroncal94 mentioned this issue Oct 7, 2020
Closed
@jkiang13 jkiang13 mentioned this issue Oct 9, 2020
Closed
@chaynsaw chaynsaw mentioned this issue Oct 12, 2020
Merged
@jkiang13 jkiang13 mentioned this issue Oct 14, 2020
Merged
knightjoel added a commit to knightjoel/zpark that referenced this issue Nov 24, 2020
@knightjoel
Bump MarkupSafe to 1.1
87622c9 
Fixes pallets/markupsafe#116
@jmilagroso
Copy link

This had been fixed since 0.19, but for some reason a revert to that fix made it into 1.0 (d2001bb), then was removed again in 1.1.

Unless you really need 1.0 for some reason, I'd advise just upgrading to 1.1.1, there shouldn't be any compatibility issues.

Thanks @davidism

smoke-b added a commit to smoke-b/pymystem3 that referenced this issue Dec 7, 2020
@smoke-b
Update Markupsafe version to fix breaking install
9bd268f 
pallets/markupsafe#116
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davidism @SgtCoDFish @jmilagroso @advance512