Small fix for installation problems under Win 64bit #3

merged 2 commits into from Jul 20, 2011


2 participants

Cito commented Jun 4, 2011

I have noticed several times that Windows installations of Python packages failed because they had MarkupSafe as dependency, but there were no Windows binaries for MarkupSafe on PyPI, and the Windows machine had no compiler installed.

Actually this should not happen because you made provisions in the file to silently ignore a missing compiler and skip compiling the extension in this case, but this never worked on any of my machines, because they always throw a ValueError instead of one of the exceptions you are catching in the file (see - seems to happen on 64 bit Win only). So I suggest catching this ValueError in addition to the other exceptions.

I can also create Win 32 and 64bit eggs for Py 2.6 and 2.7 for uploading to PyPi if you like.

mitsuhiko added a commit that referenced this pull request Jul 20, 2011

Merge pull request #3 from Cito/master
Small fix for installation problems under Win 64bit

@mitsuhiko mitsuhiko merged commit 2f39e0e into pallets:master Jul 20, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment