Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy fix support for x-forwarded-prefix #1237

Closed
ilansh opened this issue Jan 15, 2018 · 4 comments
Closed

Add proxy fix support for x-forwarded-prefix #1237

ilansh opened this issue Jan 15, 2018 · 4 comments

Comments

@ilansh
Copy link
Contributor

@ilansh ilansh commented Jan 15, 2018

This header can be useful for apps where the root path is different behind proxy, for instance in my case using the traefik proxy - https://docs.traefik.io/basics/

@davidism
Copy link
Member

@davidism davidism commented Jan 15, 2018

If the proxy is stripping the prefix and adding this header, we're supposed to detect this header and add it to the URL before matching happens?

@davidism
Copy link
Member

@davidism davidism commented Jan 15, 2018

There are some other issues open about ProxyFix not supporting all the Forwarded headers (including the real Forwarded header). If you have time to create a PR that would be very helpful.

@ilansh
Copy link
Contributor Author

@ilansh ilansh commented Jan 16, 2018

No problem, I'll try to make some time for a new PR.

@ilansh
Copy link
Contributor Author

@ilansh ilansh commented Jan 16, 2018

As far as I understand, url matching is on the stripped urls (not adding the prefix from the header).
Url building adds the prefix to the returned url.

@davidism davidism closed this May 28, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants