Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate utils.format_string #1756

Closed
davidism opened this issue Mar 16, 2020 · 3 comments · Fixed by #1764
Closed

deprecate utils.format_string #1756

davidism opened this issue Mar 16, 2020 · 3 comments · Fixed by #1764
Milestone
2.0.0

Comments

@davidism
Copy link
Member

It appears to do exactly what string.Template does.
@davidism davidism added this to the 2.0.0 milestone Mar 16, 2020
@northernSage
Copy link
Contributor

I would be glad to help with this.

@davidism
Copy link
Member Author

You're welcome to work on issues, no need to ask first. The deprecation warning should be something like 'format_string' is deprecated and will be removed in 2.1. Use 'string.Template' instead. There's a few places the function is used internally which should be replaced with string.Template, as well as the implementation itself.

@northernSage
Copy link
Contributor

Okay, I will get to it and write a PR in the next few days.

@northernSage northernSage mentioned this issue Mar 18, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Deprecate utils.format_string
2 participants
@davidism @northernSage