Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate export of utils.escape/unescape #1758

Closed
davidism opened this issue Mar 16, 2020 · 0 comments · Fixed by #1787
Closed

deprecate export of utils.escape/unescape #1758

davidism opened this issue Mar 16, 2020 · 0 comments · Fixed by #1787
Milestone

Comments

@davidism
Copy link
Member

davidism commented Mar 16, 2020

People should be using MarkupSafe instead. These utilities are here just to escape output in the debugger (and utils.HTMLBuilder, which should probably also be deprecated), where performance isn't really important. To keep them for internal use, rename them to _internal._escape and make utils.escape import that and show a deprecation warning pointing to MarkupSafe. Make sure to update use in the docs too.

@davidism davidism added this to the 2.0.0 milestone Mar 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant