send_file should have a kwarg for explicitly specifying an etag so it can be used even without a physical file where it would be autogenerated.
Right now one has to copy&paste code (the stuff from if conditional:) into their if they want to include an etag for a file that does not represent a physical file on disk, because make_conditional should ideally be used on a response that already has an etag set...
This depends on #1850 since it moves send_file from Flask to werkzeug.
send_fileshould have a kwarg for explicitly specifying an etag so it can be used even without a physical file where it would be autogenerated.Right now one has to copy&paste code (the stuff from
if conditional:) into their if they want to include an etag for a file that does not represent a physical file on disk, becausemake_conditionalshould ideally be used on a response that already has an etag set...This depends on #1850 since it moves
send_filefrom Flask to werkzeug.