Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User agents not being detected #1971

Closed
JavaScriptDude opened this issue Nov 20, 2020 · 3 comments · Fixed by #2074
Closed

User agents not being detected #1971

JavaScriptDude opened this issue Nov 20, 2020 · 3 comments · Fixed by #2074

Comments

@JavaScriptDude
Copy link

JavaScriptDude commented Nov 20, 2020

While using your utility to parse user agents for calls to my site, I have a few that don't get parsed correctly:

Version not getting parsed on the following user agents:

  • Mozilla/5.0 (Linux; Android 10; motorola edge) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.101 Mobile Safari/537.36
  • Mozilla/5.0 (Linux; Android 10; motorola edge) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.81 Mobile Safari/537.36
  • Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322)

Detected as 'mozilla' but is actually msie v11:

  • Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko
@jcorvino
Copy link

See my comments on issue #1923

We should probably merge these 2 issues since they share the same root problem.

@davidism
Copy link
Member

Happy to consider a PR that updates the matching rules.

@Saif807380
Copy link
Contributor

I'd like to work on this.

@davidism davidism added this to the 2.0.0 milestone Mar 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants