is_resource_modified() should work for methods besides GET

[zhangchunlin]

werkzeug/werkzeug/http.py

Lines 893 to 894 in 5444a6f

	if environ['REQUEST_METHOD'] not in ('GET', 'HEAD'):
	return False

If the request method is post, but I want to return a different file every time, then this should not return false.

[untitaker]

I agree. E.g. CalDAV and CardDAV use If-None-Match headers on PUT requests to prevent data-loss and avoid overwriting changed resources. I think the whole if-clause should be removed.

[untitaker]

See #615. For 1.0 we should just change the default for the new parameter to ().

EDIT: Just reverted the fix, a similar check is done in Request.make_conditional. I don't think introducing such an ugly API is worth it, postponing everything to 1.0.

[davidism]

@untitaker If you can remember, what did you have in mind for a 1.0 fix? Just allow all methods? I'm trying to read through RFC 7232 now.

[untitaker]

@davidism I think that was my intention but I am not sure if that's a good idea anymore.

[untitaker]

My edit looks like I saw an issue with it and just postponed the decisioo to 1.0 without really knowing what to do

[davidism]

As far as I can tell from the RFC the change to check is_resource_modified on all methods would have been correct. Setting the headers only happens on GET, but responding to them them can happen with any method.