Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

server_name is checked case-sensitively #99

Closed
mickael9 opened this Issue Aug 31, 2011 · 3 comments

Comments

Projects
None yet
2 participants

When the server_name variable is set and the request has a different case, (for example "MYDOMAIN.COM" instead of "mydomain.com"), werkzeug fails with the following error :

ValueError: the server name provided ('mydomain.com') does not match the server name from the WSGI environment ('MYDOMAIN.COM')"

This has caused me headaches with dot.tk cancelling my domain because their bot would set the host header to MYDOMAIN.TK and get a 500 reply.

Owner

mitsuhiko commented Aug 31, 2011

Good point. This should be fixed. In fact, I want to get rid of that ValueError altogether anyways since you can easily end up in situations where the server config dispatches requests to the app with unexpected server names. (request to IP)

mickael9 commented Sep 1, 2011

Do you mean this was already fixed before ?

Owner

mitsuhiko commented Sep 3, 2011

No, but I am fixing it right now. But there is a slightly related issue I will fix with that as well.

@mitsuhiko mitsuhiko closed this in 5639c68 Sep 3, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment