Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unix domain socket binding #1019

Merged
merged 2 commits into from May 29, 2018
Merged

Enable unix domain socket binding #1019

merged 2 commits into from May 29, 2018

Conversation

@sergiosmcr
Copy link
Contributor

@sergiosmcr sergiosmcr commented Oct 14, 2016

If hostname starts with 'unix://', assume a
unix domain socket instead of a TCP socket.

I took the original solution from @runderwood PR #209 posted 4 years ago, and adjusted it to work in latest code.

If hostname starts with 'unix://', assume a
unix domain socket instead of a TCP socket.
@dajose
Copy link

@dajose dajose commented Oct 17, 2016

@untitaker do you have some time to check this?

@sergiosmcr
Copy link
Contributor Author

@sergiosmcr sergiosmcr commented Oct 25, 2016

Can any one at Werkzeug check this?

@RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented Oct 25, 2016

at first glance the code looks good, i wont have time to test near term however

@untitaker
Copy link
Member

@untitaker untitaker commented Oct 29, 2016

LGTM too. I wonder if we can add a test for this, though test setup for the server is always very brittle...

@untitaker
Copy link
Member

@untitaker untitaker commented Oct 29, 2016

Also sorry for the super-slow response!

@sergiosmcr
Copy link
Contributor Author

@sergiosmcr sergiosmcr commented Nov 2, 2016

I'll write a test. I am not sure how to integrate it with your CIT though.

@untitaker
Copy link
Member

@untitaker untitaker commented Nov 2, 2016

I'm going to write a testcase, could you add appropriate docs? I.e. modify the docstring of run_simple and make_server and perhaps add an example in serving.rst

@sergiosmcr
Copy link
Contributor Author

@sergiosmcr sergiosmcr commented Nov 2, 2016

Sure. I will do soon

@untitaker
Copy link
Member

@untitaker untitaker commented Nov 2, 2016

Here's a testcase, I'll refactor the entire server soon

@sergiosmcr
Copy link
Contributor Author

@sergiosmcr sergiosmcr commented Nov 2, 2016

Here is the requested documentation.
make_server docstring lacked of any parameter description, so I preferred not to modify it. Let me know if this change is enough.

@sergiosmcr
Copy link
Contributor Author

@sergiosmcr sergiosmcr commented Dec 27, 2017

Hey @untitaker It's been a while since I started this and I never fixed the test...
I've just rebased and have stronger wishes to merge this.
Would you help me to fix the test?

@untitaker
Copy link
Member

@untitaker untitaker commented Dec 27, 2017

@sergiosmcr
Copy link
Contributor Author

@sergiosmcr sergiosmcr commented Dec 27, 2017

Oh ok.
Who can help me?

@davidism davidism self-assigned this May 29, 2018
@davidism davidism added this to the 0.15 milestone May 29, 2018
@davidism davidism force-pushed the master branch 2 times, most recently from bc27b72 to d520b8c May 29, 2018
@davidism
Copy link
Member

@davidism davidism commented May 29, 2018

Rebased to master, squashed, fixed git user info, added docs and changelog.

I switched this to use the dev_server fixture like the other tests, which required adding detection to the fixture and using requests_unixsocket to make the request to get the PID. This had the side effect of removing most of the test since it was taken care of by the normal behavior of the fixture.

@davidism davidism merged commit 0d6d93e into pallets:master May 29, 2018
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants