Enable unix domain socket binding

[sergiosmcr]

If hostname starts with 'unix://', assume a
unix domain socket instead of a TCP socket.

I took the original solution from @runderwood PR #209 posted 4 years ago, and adjusted it to work in latest code.

[dajose]

@untitaker do you have some time to check this?

[sergiosmcr]

Can any one at Werkzeug check this?

[RonnyPfannschmidt]

at first glance the code looks good, i wont have time to test near term however

[untitaker]

LGTM too. I wonder if we can add a test for this, though test setup for the server is always very brittle...

[untitaker]

Also sorry for the super-slow response!

[sergiosmcr]

I'll write a test. I am not sure how to integrate it with your CIT though.

[untitaker]

I'm going to write a testcase, could you add appropriate docs? I.e. modify the docstring of run_simple and make_server and perhaps add an example in serving.rst

[sergiosmcr]

Sure. I will do soon

[untitaker]

Here's a testcase, I'll refactor the entire server soon

[sergiosmcr]

Here is the requested documentation.
make_server docstring lacked of any parameter description, so I preferred not to modify it. Let me know if this change is enough.

[sergiosmcr]

Hey @untitaker It's been a while since I started this and I never fixed the test...
I've just rebased and have stronger wishes to merge this.
Would you help me to fix the test?

[untitaker]

Sorry I dont maintain this anymore.

…

On 27 December 2017 16:55:20 GMT+01:00, sergiosmcr ***@***.***> wrote: Hey @untitaker It's been a while since I started this and I never fixed the test... I've just rebased and have stronger wishes to merge this. Would you help me to fix the test? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #1019 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[sergiosmcr]

Oh ok.
Who can help me?

[davidism]

Rebased to master, squashed, fixed git user info, added docs and changelog.

I switched this to use the dev_server fixture like the other tests, which required adding detection to the fixture and using requests_unixsocket to make the request to get the PID. This had the side effect of removing most of the test since it was taken care of by the normal behavior of the fixture.