Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lighttpd version check in CGIRootFix #1141

Merged
merged 1 commit into from Nov 22, 2018

Conversation

@saltcandy123
Copy link
Contributor

@saltcandy123 saltcandy123 commented Jun 24, 2017

According to #266, CGIRootFix is not only for lighttpd now.
So, SERVER_SOFTWARE should not be assumed to start with 'lighttpd/', as this value can be 'Apache/x.x.x' (less than 'lighttpd/1.4.28') or 'nginx/x.x.x' (greater), for example.

@davidism
Copy link
Member

@davidism davidism commented Jun 25, 2017

@untitaker maybe that whole if statement can be removed?

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Jun 25, 2017

👍 on removing it. people should not use this kind of middleware unconditionally but either use a custom wsgi file applying it or add a config option to determine whether to use it or not

@untitaker
Copy link
Member

@untitaker untitaker commented Jun 25, 2017

@davidism
Copy link
Member

@davidism davidism commented Nov 22, 2018

I'm removing the entire check. It's addressing servers before Lighttpd 1.4.28, which was released in 2010. We can move on.

@davidism davidism changed the title fix lighttpd version check in CGIRootFix remove lighttpd version check in CGIRootFix Nov 22, 2018
@davidism davidism added this to the 0.15 milestone Nov 22, 2018
show deprecation for LighttpdCGIRootFix name
@davidism davidism force-pushed the fix-lighttpd-version-check branch from 4dfc709 to dc676bd Nov 22, 2018
@davidism davidism merged commit 4d30c23 into pallets:master Nov 22, 2018
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants