remove lighttpd version check in CGIRootFix#1141
Merged
davidism merged 1 commit intopallets:masterfrom Nov 22, 2018
saltcandy123:fix-lighttpd-version-check
Merged
remove lighttpd version check in CGIRootFix#1141davidism merged 1 commit intopallets:masterfrom saltcandy123:fix-lighttpd-version-check
davidism merged 1 commit intopallets:masterfrom
saltcandy123:fix-lighttpd-version-check
Conversation
Member
|
@untitaker maybe that whole if statement can be removed? |
Member
|
👍 on removing it. people should not use this kind of middleware unconditionally but either use a custom wsgi file applying it or add a config option to determine whether to use it or not |
Contributor
|
I don't understand what this code does.
…On Sat, Jun 24, 2017 at 05:19:24PM -0700, David Lord wrote:
@untitaker maybe that whole if statement can be removed?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1141 (comment)
|
Member
|
I'm removing the entire check. It's addressing servers before Lighttpd 1.4.28, which was released in 2010. We can move on. |
show deprecation for LighttpdCGIRootFix name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #266, CGIRootFix is not only for lighttpd now.
So, SERVER_SOFTWARE should not be assumed to start with
'lighttpd/', as this value can be'Apache/x.x.x'(less than'lighttpd/1.4.28') or'nginx/x.x.x'(greater), for example.