Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue using `securecookie` with Python 3 #1205

Merged

Conversation

Projects
None yet
2 participants
@grahamlyons
Copy link
Contributor

commented Dec 4, 2017

When using a string for the secret_key (as per the docs) Python 3 fails with a TypeError.

This catches the error and uses the encode method instead.

Addresses #1204

grahamlyons and others added some commits Dec 4, 2017

Fix an issue using `securecookie` with Python 3
When using a string for the `secret_key` (as per the docs) Python 3
fails with a `TypeError`.

This catches the error and uses the `encode` method instead.

Addresses #1204

@davidism davidism force-pushed the grahamlyons:fix-securecookie-bug-with-python-3 branch from f8ad5d1 to 41248bf Dec 4, 2017

@davidism davidism merged commit c9e05d0 into pallets:master Dec 4, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@davidism davidism added this to the 0.13 milestone Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.