Fix an issue using securecookie with Python 3#1205
Merged
davidism merged 2 commits intoDec 4, 2017
Conversation
When using a string for the `secret_key` (as per the docs) Python 3 fails with a `TypeError`. This catches the error and uses the `encode` method instead. Addresses pallets#1204
davidism
force-pushed
the
fix-securecookie-bug-with-python-3
branch
from
f8ad5d1 to
41248bf
Compare
This was referenced Dec 7, 2017
This was referenced Jan 5, 2018
This was referenced Jan 15, 2018
This was referenced Jan 29, 2018
This was referenced Feb 5, 2018
This was referenced Feb 13, 2018
This was referenced Feb 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a string for the
secret_key(as per the docs) Python 3 fails with aTypeError.This catches the error and uses the
encodemethod instead.Addresses #1204