Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added edge browser detection #1216

Merged

Conversation

doekman
Copy link
Contributor

@doekman doekman commented Dec 18, 2017

In response to issue #818

@mitsuhiko mitsuhiko merged commit ac7c02b into pallets:master Dec 27, 2017
@davidism davidism added this to the 0.14 milestone Jan 3, 2018
@fdenzer
Copy link

fdenzer commented Feb 6, 2019

Documentation does not seem to match this commit:
neither v0.14 nor development version of today (2018-02-06) include 'edge' as a possible user agent.

@doekman
Copy link
Contributor Author

doekman commented Feb 6, 2019

I forgot to update the docs. Luckily, someone updated it last year on master. You should have it.

@fdenzer
Copy link

fdenzer commented Feb 7, 2019

Actually, for me 'chrome' at version 64 62 is detected for Edge of our current (corporate) Windows 10.

Did detection break? UserAgentParser does hold the 'edge' case, in my testcase it is just never used. 🤔

@doekman
Copy link
Contributor Author

doekman commented Feb 7, 2019

I have version 0.14.1 of werkzeug running and it detects edge just fine. The user-agent I got from edge: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134.

@mitsuhiko About the documentation: could it be the documentation build has problems? The documentation isn't date/time stamped, and I also don't see a commit hash of the last commit.

@fdenzer
Copy link

fdenzer commented Feb 8, 2019

I guess I should open a new bug, since
('Mozilla/5.0 (Windows NT 10.0; Win64; x64; WIA enabled) AppleWebKit/537.36 ' '(KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/18.17763')

gets detected as chrome 64, not edge 18, in my werkzeug

@doekman
Copy link
Contributor Author

doekman commented Feb 8, 2019

@fdenzer I think we're missing something here. When I use your userAgent-string, it detects edge... If you open this site, at the bottom it says what user agent it detects.

Are you sure you have the mentioned werkzeug-version?

# If you use a virtual environment, don't forget to activate it.
(venv) $ pip list
Package            Version  
------------------ ---------
...
Werkzeug           0.14.1   

@fdenzer
Copy link

fdenzer commented Feb 10, 2019 via email

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants