-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added edge browser detection #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added edge browser detection #1216
Conversation
|
Documentation does not seem to match this commit: |
|
I forgot to update the docs. Luckily, someone updated it last year on master. You should have it. |
|
Actually, for me 'chrome' at version 64 Did detection break? UserAgentParser does hold the 'edge' case, in my testcase it is just never used. 🤔 |
|
I have version @mitsuhiko About the documentation: could it be the documentation build has problems? The documentation isn't date/time stamped, and I also don't see a commit hash of the last commit. |
|
I guess I should open a new bug, since gets detected as chrome 64, not edge 18, in my werkzeug |
|
@fdenzer I think we're missing something here. When I use your userAgent-string, it detects edge... If you open this site, at the bottom it says what user agent it detects. Are you sure you have the mentioned werkzeug-version? |
|
classical PEBKAC,
I was using the debian provided package, which as stated by
https://packages.debian.org/stretch/python3-werkzeug is 0.11.15 🙈
sorry for confusing my pep environments. issue withdrawn 😊
|
In response to issue #818