Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getattr(hashlib, 'algorithms', None) to #1226

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Lvl4Sword
Copy link

commented Dec 28, 2017

getattr(hashlib, 'algorithms_available', None)

getattr(hashlib, 'algorithms', None) to
getattr(hashlib, 'algorithms_available', None)
@mitsuhiko

This comment has been minimized.

Copy link
Member

commented Dec 28, 2017

The issue here is that algorithms_available and algorithms are doing different things. So I need to verify if changing one for the other actually works here.

@Lvl4Sword

This comment has been minimized.

Copy link
Author

commented Dec 28, 2017

That's part of an issue I've bumped into, actually. It seems like Python 3.5 is interesting, as Blake isn't natively supported, but it's provided by my OpenSSL version. So, I'll poke at this a little more and see what I can do.

@mitsuhiko

This comment has been minimized.

Copy link
Member

commented Dec 28, 2017

@Lvl4Sword I think the correct thing to do here would be to stop using our hack and instead use hashlib.new for string algorithm values.

@Lvl4Sword

This comment has been minimized.

Copy link
Author

commented Dec 28, 2017

That's something I'm all for! Would be better than what's being used currently 😃

@mitsuhiko

This comment has been minimized.

Copy link
Member

commented Dec 28, 2017

This code predates hashlib so a lot of what's there now does not really make sense any more in 2017. I'm happy to have this changed. Not sure if I can do it right now though.

@davidism

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

@Lvl4Sword are you able to follow up and get this more in line with hashlib? We only support Python 2.7 and 3.4+ now, so that might make things easier.

@Lvl4Sword

This comment has been minimized.

Copy link
Author

commented Jan 24, 2018

@davidism My initial approach was very poor, and it looks like there's more to be done than what I had.
There are a few things I'm working on currently, but it's something I'd like to help with when I can.

lepture added a commit that referenced this pull request Apr 21, 2018

@lepture

This comment has been minimized.

Copy link
Member

commented Apr 21, 2018

Close it in favor of #1282

@lepture lepture closed this Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.