Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClosingIterator closes iterable passed to it and not the iterator #1260

Merged

Conversation

@romank0
Copy link
Contributor

@romank0 romank0 commented Mar 2, 2018

This fixes #1259.

According to wsgi specification:

If the iterable returned by the application has a close() method, the
server or gateway must call that method upon completion of the current
request

This commit adds test for this and fixes the issue.

@romank0 romank0 closed this Mar 5, 2018
@romank0 romank0 reopened this Mar 5, 2018
romank0 and others added 2 commits May 29, 2018
This is a fix for pallets#1259.

According to [wsgi specification](https://www.python.org/dev/peps/pep-3333):

> If the iterable returned by the application has a close() method, the
> server or gateway must call that method upon completion of the current
> request

This commit adds test for this and fixes the issue.
@davidism davidism force-pushed the 1259-closing-iterator-closes-iterable branch from 478b487 to f048c0b May 30, 2018
@davidism davidism added this to the 0.15 milestone May 30, 2018
@davidism davidism merged commit 5340abb into pallets:master May 30, 2018
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants