Modernize security module, remove _find_hashlib_algorithms.#1282
Merged
Conversation
davidism
reviewed
Apr 21, 2018
This was referenced Apr 21, 2018
davidism
approved these changes
Apr 21, 2018
Member
|
Nice to remove all that code. 👍 Remember to add a changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup the code via #1226 (comment)
Here is a breaking change
_hash_internal, it once raisedTypeErrorwhen hash func was invalid. However, the default behavior ofhashlib.neworhmac.HMACis raisingValueError. You can find the breaking change in test case.