Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize security module, remove _find_hashlib_algorithms. #1282

Merged
merged 3 commits into from Apr 21, 2018
Merged

Conversation

@lepture
Copy link
Member

@lepture lepture commented Apr 21, 2018

Cleanup the code via #1226 (comment)

Here is a breaking change _hash_internal, it once raised TypeError when hash func was invalid. However, the default behavior of hashlib.new or hmac.HMAC is raising ValueError. You can find the breaking change in test case.

werkzeug/security.py Outdated Show resolved Hide resolved
Loading
@davidism
Copy link
Member

@davidism davidism commented Apr 21, 2018

Nice to remove all that code. 👍 Remember to add a changelog entry.

Loading

@lepture lepture merged commit 0751573 into master Apr 21, 2018
1 of 2 checks passed
Loading
@lepture lepture deleted the patch-security branch Apr 21, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants