Skip to content

Ignore empty cookie keys#1301

Merged
davidism merged 1 commit into
pallets:masterfrom
yanigisawa:1245-empty-cookie-keys
May 23, 2018
Merged

Ignore empty cookie keys#1301
davidism merged 1 commit into
pallets:masterfrom
yanigisawa:1245-empty-cookie-keys

Conversation

@yanigisawa
Copy link
Copy Markdown
Contributor

@yanigisawa yanigisawa commented May 14, 2018

Without this check for the 'key' variable, there is an empty key in the resulting dictionary, e.g:

{ 
   'first': u'IamTheFirst', 
   'a': u'2', 
   'second': u'andMeTwo', 
   '': '' 
}

closes #1245

@lepture
Copy link
Copy Markdown
Contributor

lepture commented May 15, 2018

Manually triggered re-build. There is a style error, please fix it by validating with flake8.

@yanigisawa
Copy link
Copy Markdown
Contributor Author

Flake8 issue resolved

@davidism davidism changed the title GH #1234 - Ignore empty cookie keys Ignore empty cookie keys May 23, 2018
@davidism davidism force-pushed the 1245-empty-cookie-keys branch from 6ae9109 to 8eb0b73 Compare May 23, 2018 15:37
@davidism davidism merged commit 498ac1a into pallets:master May 23, 2018
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parse_cookie(): Does not ignore empty cookies

3 participants