Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty cookie keys #1301

merged 1 commit into from May 23, 2018


Copy link

@yanigisawa yanigisawa commented May 14, 2018

Without this check for the 'key' variable, there is an empty key in the resulting dictionary, e.g:

   'first': u'IamTheFirst', 
   'a': u'2', 
   'second': u'andMeTwo', 
   '': '' 

closes #1245

Copy link

lepture commented May 15, 2018

Manually triggered re-build. There is a style error, please fix it by validating with flake8.

Copy link
Contributor Author

Flake8 issue resolved

@davidism davidism changed the title GH #1234 - Ignore empty cookie keys Ignore empty cookie keys May 23, 2018
@davidism davidism merged commit 498ac1a into pallets:master May 23, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

parse_cookie(): Does not ignore empty cookies
3 participants