Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty cookie keys #1301

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
3 participants
@yanigisawa
Copy link
Contributor

commented May 14, 2018

Without this check for the 'key' variable, there is an empty key in the resulting dictionary, e.g:

{ 
   'first': u'IamTheFirst', 
   'a': u'2', 
   'second': u'andMeTwo', 
   '': '' 
}

closes #1245

@lepture

This comment has been minimized.

Copy link
Member

commented May 15, 2018

Manually triggered re-build. There is a style error, please fix it by validating with flake8.

@yanigisawa

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2018

Flake8 issue resolved

@davidism davidism changed the title GH #1234 - Ignore empty cookie keys Ignore empty cookie keys May 23, 2018

@davidism davidism force-pushed the yanigisawa:1245-empty-cookie-keys branch from 6ae9109 to 8eb0b73 May 23, 2018

@davidism davidism merged commit 498ac1a into pallets:master May 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.