Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore X-Forwarded-Host in get_host() #1303

Merged
merged 3 commits into from May 23, 2018

Conversation

Projects
None yet
2 participants
@tuukkamustonen
Copy link

commented May 15, 2018

Ref #609.

Also:

  • Polished and improved tests a bit.
  • Have get_host() remove standard ports (80, 443)
  • Re-use get_host() in Map#bind_to_environ() to remove duplication.
Tuukka Mustonen
`get_host()` now ignores `X-Forwarded-Host`
To get `X-Forwarded-*` headers considered, use `ProxyFix`.

This also adds more tests for werkzeug.wsgi.get_host().

@tuukkamustonen tuukkamustonen force-pushed the tuukkamustonen:fix-609 branch from 0b5a686 to eef69fe May 15, 2018

@tuukkamustonen tuukkamustonen force-pushed the tuukkamustonen:fix-609 branch from 4b96458 to ae9591d May 15, 2018

@tuukkamustonen tuukkamustonen force-pushed the tuukkamustonen:fix-609 branch from ae9591d to fbb27e0 May 15, 2018

@davidism davidism merged commit 05f8cb6 into pallets:master May 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tuukkamustonen tuukkamustonen deleted the tuukkamustonen:fix-609 branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.