Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore X-Forwarded-Host in get_host() #1303

Merged
merged 3 commits into from May 23, 2018
Merged

Conversation

@tuukkamustonen
Copy link

@tuukkamustonen tuukkamustonen commented May 15, 2018

Ref #609.

Also:

  • Polished and improved tests a bit.
  • Have get_host() remove standard ports (80, 443)
  • Re-use get_host() in Map#bind_to_environ() to remove duplication.
To get `X-Forwarded-*` headers considered, use `ProxyFix`.

This also adds more tests for werkzeug.wsgi.get_host().
@davidism davidism merged commit 05f8cb6 into pallets:master May 23, 2018
1 check passed
@tuukkamustonen tuukkamustonen deleted the fix-609 branch Jun 18, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants