Keep terminal input when triggering code reload during breakpoint#1318
Merged
davidism merged 2 commits intoMay 29, 2018
Conversation
Member
|
Please ensure the tests pass in a clean environment with |
Member
Contributor
Author
|
@davidism Thanks for the feedback here. Fixed on both counts |
|
This looks similar to what Django has. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to fix #1317
Would add a test but the actual bugfix that depends on this would be a pretty bizarre thing to test, not sure how that might be automated in a practical fashion. A unit test here would be pretty meaningless w/regards to the actual issue. Happy to add any test that seems appropriate though (will fix that now-broken test in a moment)
This is pretty much just how Pyramid/Django both do it, with slight recontextualizing because licensing requirements are somewhat unclear