Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep terminal input when triggering code reload during breakpoint #1318

Merged
merged 2 commits into from May 29, 2018

Conversation

Projects
None yet
3 participants
@bpicolo
Copy link
Contributor

commented May 29, 2018

Seems to fix #1317

Would add a test but the actual bugfix that depends on this would be a pretty bizarre thing to test, not sure how that might be automated in a practical fashion. A unit test here would be pretty meaningless w/regards to the actual issue. Happy to add any test that seems appropriate though (will fix that now-broken test in a moment)

This is pretty much just how Pyramid/Django both do it, with slight recontextualizing because licensing requirements are somewhat unclear

@davidism

This comment has been minimized.

Copy link
Member

commented May 29, 2018

Please ensure the tests pass in a clean environment with tox -e py36. This appears to be causing issues with connections in test_serving.py for some reason. https://travis-ci.org/pallets/werkzeug/jobs/385255469#L532

@davidism

This comment has been minimized.

Copy link
Member

commented May 29, 2018

Your git config does not appear to match your GitHub profile. If you want those to match up you need to configure your name and email. After that, amend the author information to the existing commit with git commit --amend --author 'Your Name <configured@email>', then force push with git push -f.

@bpicolo bpicolo force-pushed the bpicolo:1317-fix-terminput-after-pdb-reload branch 2 times, most recently from 464789d to e953901 May 29, 2018

@bpicolo

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2018

@davidism Thanks for the feedback here. Fixed on both counts

@davidism davidism force-pushed the bpicolo:1317-fix-terminput-after-pdb-reload branch from e953901 to 90273ac May 29, 2018

@davidism davidism force-pushed the bpicolo:1317-fix-terminput-after-pdb-reload branch from 90273ac to e19a175 May 29, 2018

@davidism davidism merged commit 9cdcb93 into pallets:master May 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@blueyed

This comment has been minimized.

Copy link

commented Apr 27, 2019

This looks similar to what Django has.
I've made an improvement over there: https://github.com/django/django/pull/11291/files
I'd appreciate feedback, and could also turn it into a PR here if you want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.