Skip to content

Keep terminal input when triggering code reload during breakpoint#1318

Merged
davidism merged 2 commits into
pallets:masterfrom
bpicolo:1317-fix-terminput-after-pdb-reload
May 29, 2018
Merged

Keep terminal input when triggering code reload during breakpoint#1318
davidism merged 2 commits into
pallets:masterfrom
bpicolo:1317-fix-terminput-after-pdb-reload

Conversation

@bpicolo
Copy link
Copy Markdown
Contributor

@bpicolo bpicolo commented May 29, 2018

Seems to fix #1317

Would add a test but the actual bugfix that depends on this would be a pretty bizarre thing to test, not sure how that might be automated in a practical fashion. A unit test here would be pretty meaningless w/regards to the actual issue. Happy to add any test that seems appropriate though (will fix that now-broken test in a moment)

This is pretty much just how Pyramid/Django both do it, with slight recontextualizing because licensing requirements are somewhat unclear

@davidism
Copy link
Copy Markdown
Member

davidism commented May 29, 2018

Please ensure the tests pass in a clean environment with tox -e py36. This appears to be causing issues with connections in test_serving.py for some reason. https://travis-ci.org/pallets/werkzeug/jobs/385255469#L532

@davidism
Copy link
Copy Markdown
Member

davidism commented May 29, 2018

Your git config does not appear to match your GitHub profile. If you want those to match up you need to configure your name and email. After that, amend the author information to the existing commit with git commit --amend --author 'Your Name <configured@email>', then force push with git push -f.

@bpicolo
Copy link
Copy Markdown
Contributor Author

bpicolo commented May 29, 2018

@davidism Thanks for the feedback here. Fixed on both counts

@davidism davidism merged commit 9cdcb93 into pallets:master May 29, 2018
@blueyed
Copy link
Copy Markdown

blueyed commented Apr 27, 2019

This looks similar to what Django has.
I've made an improvement over there: https://github.com/django/django/pull/11291/files
I'd appreciate feedback, and could also turn it into a PR here if you want it.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggering a code reload during a PDB session breaks terminal input

3 participants