Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if query string has multiple definitions #1338

Merged
merged 1 commit into from Jul 29, 2018

Conversation

Projects
None yet
2 participants
@pgjones
Copy link
Member

commented Jul 29, 2018

Previously to this commit if when creating an environ (i.e. for
testing) a query string is defined in the path and as an argument the
path-query-string would be ignored. This results in the path not
matching any routes and hence an unexpected result. This commit fixes
this issue by raising a ValueError if someone should do this.

Raising ValueError is considered the correct approach as it is unclear
which individual query string is the user's intention or if they
should be combined.

Raise an error if query string has multiple definitions
Previously to this commit if when creating an environ (i.e. for
testing) a query string is defined in the path and as an argument the
path-query-string would be ignored. This results in the path not
matching any routes and hence an unexpected result. This commit fixes
this issue by raising a ValueError if someone should do this.

Raising ValueError is considered the correct approach as it is unclear
which individual query string is the user's intention or if they
should be combined.

@davidism davidism merged commit 816a1e9 into pallets:master Jul 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davidism

This comment has been minimized.

Copy link
Member

commented Jul 29, 2018

Thanks, I added a changelog entry in master. Remember to use separate branches for PRs. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.