Raise an error if query string has multiple definitions#1338
Merged
Conversation
Previously to this commit if when creating an environ (i.e. for testing) a query string is defined in the path and as an argument the path-query-string would be ignored. This results in the path not matching any routes and hence an unexpected result. This commit fixes this issue by raising a ValueError if someone should do this. Raising ValueError is considered the correct approach as it is unclear which individual query string is the user's intention or if they should be combined.
Member
|
Thanks, I added a changelog entry in master. Remember to use separate branches for PRs. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously to this commit if when creating an environ (i.e. for
testing) a query string is defined in the path and as an argument the
path-query-string would be ignored. This results in the path not
matching any routes and hence an unexpected result. This commit fixes
this issue by raising a ValueError if someone should do this.
Raising ValueError is considered the correct approach as it is unclear
which individual query string is the user's intention or if they
should be combined.